[link-local]Modify RIF check to include link-local enabled interfaces #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
approved these changes
Sep 22, 2022
prsunny
approved these changes
Sep 22, 2022
yxieca
pushed a commit
that referenced
this pull request
Sep 22, 2022
…#2394) * Modify RIF check to include interfaces with link-local mode. The existing RIF check will only work if the key is tuple which is applicable only when interface has IP address. However if the interface has IPv6 only enable the key is of type string. So in common if the interface is either IPv6 enabled or ip configured it has both string and tuple keys as illustrated below. Hence modified the if check to check directly for interface name which will match the key of type string
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Sep 22, 2022
Update sonic-utilities submodule pointer to include the following: * 99ed8ea [link-local]Modify RIF check to include link-local enabled interfaces ([sonic-net#2394](sonic-net/sonic-utilities#2394)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
7 tasks
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Sep 26, 2022
Update sonic-utilities submodule pointer to include the following: * 99ed8ea [link-local]Modify RIF check to include link-local enabled interfaces ([#2394](sonic-net/sonic-utilities#2394)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com> Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
EdenGri
pushed a commit
to EdenGri/sonic-utilities
that referenced
this pull request
Oct 12, 2022
…sonic-net#2394) * Modify RIF check to include interfaces with link-local mode. The existing RIF check will only work if the key is tuple which is applicable only when interface has IP address. However if the interface has IPv6 only enable the key is of type string. So in common if the interface is either IPv6 enabled or ip configured it has both string and tuple keys as illustrated below. Hence modified the if check to check directly for interface name which will match the key of type string
mdanish-kh
pushed a commit
to hamnarauf/sonic-utilities
that referenced
this pull request
Oct 22, 2022
…sonic-net#2394) * Modify RIF check to include interfaces with link-local mode. The existing RIF check will only work if the key is tuple which is applicable only when interface has IP address. However if the interface has IPv6 only enable the key is of type string. So in common if the interface is either IPv6 enabled or ip configured it has both string and tuple keys as illustrated below. Hence modified the if check to check directly for interface name which will match the key of type string
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
…sonic-net#2394) * Modify RIF check to include interfaces with link-local mode. The existing RIF check will only work if the key is tuple which is applicable only when interface has IP address. However if the interface has IPv6 only enable the key is of type string. So in common if the interface is either IPv6 enabled or ip configured it has both string and tuple keys as illustrated below. Hence modified the if check to check directly for interface name which will match the key of type string
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Modify RIF check to include interfaces with link-local mode. The existing RIF check will only work if the key is tuple which is applicable only when interface has IP address. However if the interface has IPv6 only enable the key is of type string.
So in common if the interface is either IPv6 enabled or ip configured it has both string and tuple keys as illustrated below. Hence modified the if check to check directly for interface name which will match the key of type string
127.0.0.1:6379[4]> keys INTERFACE|Ethernet48
"INTERFACE|Ethernet48"
"INTERFACE|Ethernet48|1.1.1.1/16"
127.0.0.1:6379[4]> keys INTERFACE|Ethernet0
"INTERFACE|Ethernet0"
How I did it
Modified the logic to check if port has Router interface
How to verify it
Added UT to verify it.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)